Re: [PATCH v3 01/11] tracing: Include linux/types.h in trace_remote_event.h

Hi Steve,

On Tue, 11 Aug 2026 at 00:30, Steven Rostedt [off-list ref] wrote:

On Tue,  4 Aug 2026 12:23:07 +0100
Fuad Tabba [off-list ref] wrote:

quoted

trace_remote_event.h uses bool without including linux/types.h, so a
translation unit that includes it ahead of anything else that pulls
types.h in fails to build, as with nvhe/trace.h at EL2.

Fixes: 072529158e60 ("tracing: Add events to trace remotes")

Is there a config that already fails the build without this change? Or is
it that new code will fail without it?

If it is the former, please drop the fixes tag, as nothing is currently
broken. If it is the latter, then sure, keep it, but you should mention
what config options break with it.

I checked the include graph and tested by building with configurations
that could potentially fail. Nothing does. I dropped the fixes tag in
the branch I have based on kvmarm/next in case Oliver/Marc want to go
that route [1], or I'll respin it on the latest tag once kvmarm/next
has gone in to the next tag.

Cheers,
/fuad

[1] https://android-kvm.googlesource.com/linux/+/refs/heads/tabba/pkvm-hostva-kvmarm-next

-- Steve

quoted

Acked-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Fuad Tabba <fuad.tabba@linux.dev>
---
 include/linux/trace_remote_event.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/trace_remote_event.h b/include/linux/trace_remote_event.h
index c8ae1e1f5e721..e4cc2d4497bcf 100644
--- a/include/linux/trace_remote_event.h
+++ b/include/linux/trace_remote_event.h

@@ -3,6 +3,8 @@
 #ifndef _LINUX_TRACE_REMOTE_EVENTS_H
 #define _LINUX_TRACE_REMOTE_EVENTS_H

+#include <linux/types.h>
+
 struct trace_remote;
 struct trace_event_fields;
 struct trace_seq;