Thread (42 messages) flat view 42 messages, 4 authors, 1h ago

Re: [PATCH v7 12/23] firmware: arm_scmi: Add support for boot-on Telemetry

From: Fayssal Benmlih <hidden>
Date: 2026-08-03 22:59:46
Also in: arm-scmi, linux-doc, lkml

Hi Cristian,

One error-handling issue inline.
	for (int i = 0; i < ti->info.base.num_groups; i++)
		scmi_telemetry_group_config_lookup(ti,
						   &rinfo->grps[i]);

	rinfo->num_groups = ti->info.base.num_groups;

	return 0;
The return value from every group configuration lookup is discarded.

If firmware rejects one lookup or returns a transport error, that group is
still exposed with zero/default cached state, rinfo->num_groups includes
it, and enumeration is reported as successful.

Please propagate the first error, or explicitly mark individual group
state as unavailable while preserving the partial-enumeration status.

Thanks,
Fayçal

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help