Re: [PATCH 08/21] dt-bindings: mfd: x-powers: add AC200
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-08-03 07:07:40
Also in:
linux-devicetree, linux-rockchip, linux-sunxi, lkml, netdev
On 03/08/2026 07:14, James Hilliard wrote:
The AC200 is an I2C-controlled mixed-signal companion IC containing audio, video, RTC and Fast Ethernet PHY functions.
This fails when applied, because you did not explain the dependencies/merging of this patchset. This is THE MOST important information of cover letter. The first thing to explain.
Describe the parent device, its input clock, required function supplies, the optional SID bandgap calibration cell used by the vendor initialization sequence, and its optional Ethernet PHY control child. Document the 24 and 27 MHz rates encoded by the public EPHY clock selector.
...
+required: + - compatible + - reg + - clocks + - ac-ldoin-supply + - ephy-vcc-supply + - rtc-vcc-supply + - tv-vcc-supply + +dependencies: + interrupts: [ interrupt-controller ] + interrupt-controller: [ '#interrupt-cells', interrupts ] + '#interrupt-cells': [ interrupt-controller ] + nvmem-cells: [ nvmem-cell-names ] + nvmem-cell-names: [ nvmem-cells ]
Why do you need all these dependencies? What are you trying to express?
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ mixed-signal@10 {...
quoted hunk ↗ jump to hunk
+...diff --git a/include/dt-bindings/mfd/x-powers,ac200.h b/include/dt-bindings/mfd/x-powers,ac200.h new file mode 100644 index 000000000000..cc59e2ab4912 --- /dev/null +++ b/include/dt-bindings/mfd/x-powers,ac200.h@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Interrupt numbers of the X-Powers AC200 interrupt controller. + */ + +#ifndef _DT_BINDINGS_MFD_X_POWERS_AC200_H +#define _DT_BINDINGS_MFD_X_POWERS_AC200_H + +#define AC200_IRQ_TVE 0 +#define AC200_IRQ_EPHY 1 +#define AC200_IRQ_RTC 2
Hardware constants are not really bindings, even though you use them in the driver.
+ +#endif /* _DT_BINDINGS_MFD_X_POWERS_AC200_H */
Best regards, Krzysztof