Re: [PATCH v2 1/3] dt-bindings: thermal: sun8i: Add binding for the A80 THS controller
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-07-24 07:09:58
Also in:
linux-devicetree, linux-pm, linux-sunxi, lkml
On Wed, Jul 22, 2026 at 11:00:44PM +0200, Sören Hantel wrote:
The Allwinner A80 has a thermal sensor with four channels which shares its MMIO block, bus gate, module clock and reset line with the GPADC. Register-wise it is an early version of the THS found in the A83T and later SoCs, with the THS registers starting at offset 0x40 of the shared block. Add the compatible to the sun8i THS binding. The A80 takes a bus and a module clock plus a reset line, so the existing conditionals already describe it correctly. Co-authored-by: Claude Fable 5 [off-list ref]
NAK. Tools cannot certify DCO, cannot be authors.
Signed-off-by: Sören Hantel <redacted>
Messed DCO even more.
quoted hunk ↗ jump to hunk
--- .../devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml | 1 + 1 file changed, 1 insertion(+)diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml index 3e61689..718c44d 100644 --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml@@ -18,6 +18,7 @@ properties: - allwinner,sun8i-a83t-ths - allwinner,sun8i-h3-ths - allwinner,sun8i-r40-ths + - allwinner,sun9i-a80-ths
Really, single compatible was co-authored by the tool? Folks cannot write a single line of code nowadays or how does it work exactly? And the tool did not even read the rules about sending patches, DCO, proper subject for DT bindings? What is the use of the tool if it produces obviously incorrect patch? subject: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23 Ask your tool to read the docs before using it, please. Best regards, Krzysztof