[PATCH v5 00/10] phy: rockchip: samsung-hdptx: Clock fixes and API transition cleanups
From: Cristian Ciocaltea <hidden>
Date: 2026-07-23 19:41:54
Also in:
linux-phy, linux-rockchip, lkml
This series provides a set of bug fixes and cleanups for the Rockchip Samsung HDPTX PHY driver. The first part of the series addresses clock rate calculation and synchronization issues. Specifically, it fixes edge cases where the PHY PLL is pre-programmed by an external component (like a bootloader) or when changing the color depth (bpc) while keeping the modeline constant. Because the Common Clock Framework .set_rate() callback might not be invoked if the pixel clock remains unchanged, this previously led to out-of-sync states between CCF and the actual HDMI PHY configuration. The second part focuses on code cleanups and modernizing the register access. Now that dw_hdmi_qp driver has fully switched to using phy_configure(), we can drop the deprecated TMDS rate setup workarounds and the restrict_rate_change flag logic. Finally, it refactors the driver to consistently use standard bitfield macros. Signed-off-by: Cristian Ciocaltea <redacted> --- Changes in v5: - Collected R-b/T-b tags from Dmitry, Andy & Diederik - Added new patch to guard against clk rate integer underflow (Sashiko) - Updated debug message in "Prevent divide-by-zero when computing clk rate" to be consistent with the one introduced in the "underflow" patch above - Added separate patch to consolidate consumer_put in rk_hdptx_phy_power_on() error path (Dmitry) - Rebased series onto latest phy/next - Link to v4: https://patch.msgid.link/20260612-hdptx-clk-fixes-v4-0-ce5e1d456cda@collabora.com Changes in v4: - Added new patches to address new findings from Sashiko: * Prevent divide-by-zero when computing clk rate * Fix rate recalculation for 3.2GHz FRL - Updated patch "Consistently use bitfield macros" to handle a few more bit operations - Link to v3: https://patch.msgid.link/20260611-hdptx-clk-fixes-v3-0-67b1b0c00e16@collabora.com Changes in v3: - Replaced div_u64() with DIV_ROUND_CLOSEST_ULL() in Patch 1 (Sashiko) - Fixed theoretical usage_count unbalanced issue in Patch 2 (Sashiko) - Rebased series onto latest phy/next - Link to v2: https://patch.msgid.link/20260511-hdptx-clk-fixes-v2-0-664e41379cab@collabora.com Changes in v2: - Collected Tested-by tags from Thomas and Simon - Fixed a typo in commit description of patch 1 - Added a comment in patch 2 explaining why PLL config errors are ignored for rk_hdptx_phy_consumer_get() - Added a missed FIELD_GET conversion for lcpll_hw.pms_sdiv in patch 6 - Rebased onto latest phy/fixes - Link to v1: https://lore.kernel.org/r/20260227-hdptx-clk-fixes-v1-0-f998f2762d0f@collabora.com (local) --- Cristian Ciocaltea (10): phy: rockchip: samsung-hdptx: Fix rate recalculation for high bpc phy: rockchip: samsung-hdptx: Prevent divide-by-zero when computing clk rate phy: rockchip: samsung-hdptx: Guard against clk rate integer underflow phy: rockchip: samsung-hdptx: Fix rate recalculation for 3.2GHz FRL phy: rockchip: samsung-hdptx: Handle uncommitted PHY config changes phy: rockchip: samsung-hdptx: Drop TMDS rate setup workaround phy: rockchip: samsung-hdptx: Consolidate consumer_put on error path phy: rockchip: samsung-hdptx: Drop restrict_rate_change handling phy: rockchip: samsung-hdptx: Simplify GRF access with FIELD_PREP_WM16() phy: rockchip: samsung-hdptx: Consistently use bitfield macros drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 276 +++++++++++----------- 1 file changed, 138 insertions(+), 138 deletions(-) --- base-commit: ee6aa0f01d4e8eddf1c7fda49d65c7ef12444e78 change-id: 20260227-hdptx-clk-fixes-47426632f862