[PATCH 06/36] drm: remove conditional return with no effect
From: Sang-Heon Jeon <hidden>
Date: 2026-07-23 18:46:14
Also in:
cocci, dri-devel, imx, lkml, nouveau
Subsystem:
drm driver for nvidia geforce/quadro gpus, drm drivers, drm drivers and misc gpu patches, drm drivers for freescale imx 5/6, drm drivers for ti lcdc, drm panel drivers, the rest · Maintainers:
Lyude Paul, Danilo Krummrich, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Philipp Zabel, Jyri Sarha, Tomi Valkeinen, Neil Armstrong, Linus Torvalds
Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon <redacted> --- drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 6 +----- drivers/gpu/drm/nouveau/dispnv50/disp.c | 14 +++++--------- drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c | 7 +------ drivers/gpu/drm/tilcdc/tilcdc_drv.c | 6 +----- 4 files changed, 8 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c b/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
index 51a0ec043248..52a2334be799 100644
--- a/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c@@ -55,11 +55,7 @@ static int imx_drm_atomic_check(struct drm_device *dev, return ret; /* Assign PRG/PRE channels and check if all constrains are satisfied. */ - ret = ipu_planes_assign_pre(dev, state); - if (ret) - return ret; - - return ret; + return ipu_planes_assign_pre(dev, state); } static const struct drm_mode_config_funcs imx_drm_mode_config_funcs = {
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index 364227f5456f..e8fde399acae 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c@@ -301,19 +301,15 @@ nv50_dmac_create(struct nouveau_drm *drm, if (ret) return ret; - ret = nvif_object_ctor(&dmac->base.user, "kmsVramCtxDma", NV50_DISP_HANDLE_VRAM, - NV_DMA_IN_MEMORY, - &(struct nv_dma_v0) { + return nvif_object_ctor(&dmac->base.user, "kmsVramCtxDma", NV50_DISP_HANDLE_VRAM, + NV_DMA_IN_MEMORY, + &(struct nv_dma_v0) { .target = NV_DMA_V0_TARGET_VRAM, .access = NV_DMA_V0_ACCESS_RDWR, .start = 0, .limit = device->info.ram_user - 1, - }, sizeof(struct nv_dma_v0), - &dmac->vram); - if (ret) - return ret; - - return ret; + }, sizeof(struct nv_dma_v0), + &dmac->vram); } /******************************************************************************
diff --git a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
index 2334b77f348c..16a02527285e 100644
--- a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
+++ b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c@@ -58,13 +58,8 @@ static int osd101t2587_panel_prepare(struct drm_panel *panel) static int osd101t2587_panel_enable(struct drm_panel *panel) { struct osd101t2587_panel *osd101t2587 = ti_osd_panel(panel); - int ret; - ret = mipi_dsi_turn_on_peripheral(osd101t2587->dsi); - if (ret) - return ret; - - return ret; + return mipi_dsi_turn_on_peripheral(osd101t2587->dsi); } static const struct drm_display_mode default_mode_osd101t2587 = {
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 1d6c9a423a41..990805f1fea6 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c@@ -64,11 +64,7 @@ static int tilcdc_atomic_check(struct drm_device *dev, * tilcdc ->atomic_check can update ->mode_changed if pixel format * changes, hence will we check modeset changes again. */ - ret = drm_atomic_helper_check_modeset(dev, state); - if (ret) - return ret; - - return ret; + return drm_atomic_helper_check_modeset(dev, state); } static const struct drm_mode_config_funcs mode_config_funcs = {
--
2.43.0