Thread (24 messages) 24 messages, 9 authors, 1d ago

Re: [PATCH 3/8] iommu/fsl: use platform_device_set_fwnode()

From: Bartosz Golaszewski <brgl@kernel.org>
Date: 2026-07-20 13:39:48
Also in: driver-core, imx, linux-arm-msm, linux-i2c, linux-iommu, linux-pm, linux-sound, linuxppc-dev, lkml, netdev

On Mon, 20 Jul 2026 14:58:27 +0200, Robin Murphy [off-list ref] said:
On 20/07/2026 10:24 am, Bartosz Golaszewski wrote:
quoted
Prefer the higher-level platform_device_set_fwnode() over the
OF-specific platform_device_set_of_node() for dynamically allocated
platform devices.
This is very much non-portable code specific to OF-only platforms, but
if the intention is to remove platform_device_set_of_node() again
already, then FWIW,
Providing platform_device_set_of_node() and using it was done to make the
transision to expanding reference counting to all firmware nodes possible.
I don't think we'll remove it just yet as it doesn't make sense to convert
the code under drivers/of/ to using the fwnode variant.
Acked-by: Robin Murphy <robin.murphy@arm.com>

(Although I'm slightly puzzled by the cover letter - AFAICS in -next,
platform_device_set_of_node() is itself very much a user of
platform_device_set_fwnode(), however in terms of symbol exports,
perhaps the former could now just be a static inline wrapper?)
Sure that can be done independently later.

Bart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help