Thread (13 messages) 13 messages, 3 authors, 7d ago

Re: [PATCH v7 8/8] mmc: sdhci-esdhc-imx: fix resume error handling

From: Dan Carpenter <hidden>
Date: 2026-07-17 11:53:08
Also in: imx, linux-mmc, lkml

Oh, heh.  I missed the entire point of the patch...  It should have
just been:

	ret = pm_runtime_force_resume(dev);
+	if (ret)
+		return ret;

Another way to silence the Sashiko warning about missing cleanup if
mmc_gpio_set_cd_wake() failed would be to add a comment.

	ret = mmc_gpio_set_cd_wake(host->mmc, false);
	if (ret) {
		/* Just leak. It's fine. This path is impossible in 2026. */
		return ret;
	}

The other change was unrelated.

regards,
dan carpenter

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help