Re: [PATCH v2 00/12] arm64: dts: rockchip: Add NanoPi M6 board
From: Jonas Karlman <jonas@kwiboo.se>
Date: 2026-07-12 18:26:14
Also in:
linux-devicetree, linux-rockchip
Hi Joachim, On 7/12/2026 8:00 PM, Joachim Eastwood wrote:
Hi Jonas, On Sat, 11 Jul 2026 at 01:36, Jonas Karlman [off-list ref] wrote:quoted
Hi Joachim, On 7/11/2026 12:11 AM, Joachim Eastwood via B4 Relay wrote:quoted
This patch series add support for the NanoPi M6. This board is very similar to the NanoPi R6C and R6S boards which are already supported. Main differences: * M.2 M-key slot with PCIe (Also present on R6C) * M.2 E-key slot with PCIe and USB (from hub) * 1 additional USB 2.0 port from an on-board USB hub * RT5616 audio CODEC Patch 2 and 3 moves a bit code around. Please let me know if those two should be squashed together. Next few patches adds some missing bits the common nanopi dtsi file. While the final patch adds support for NanoPi M6. Support for M6 has been split into two files one dtsi and one dts file. This is to make it easier to add support to the new M6V2 board at a later stage.In my personal opinion I think it would make more sense to sort patches in following order: - adding/fixing missing bits to the common nanopi-r6 dtsi - extract M6/R6 common parts from nanopi-r6 dtsi to nanopi dtsi, nanopi-r6 dtsi includes the nanopi dtsi and no changes to dts files - final parts that adds the M6 board Should probably make it a little bit easier to cherry-pick and bisect.If the additions/missing bits needs to backported I agree.
There are consumers of DTs outside of Linux, e.g. U-Boot, that may need/want to cherry-pick patches/fixes, so such ordering should likely help for such use-cases.
I'll cook up a patch set with the order you suggest. Thanks for the feedback.
Sounds good, thanks! Regards, Jonas
best regards, Joachim Eastwood