Thread (1 message) 1 message, 1 author, 7d ago
WARM2d

[PATCH 18/26] dmaengine: stm32-stm32-dma: Remove redundant dev_err()/dev_err_probe()

From: Pan Chuang <hidden>
Date: 2026-07-09 13:59:45
Also in: dmaengine, lkml
Subsystem: dma generic offload engine subsystem, stm32 dma drivers, the rest · Maintainers: Vinod Koul, Amélie Delaunay, Linus Torvalds

The devm_request_irq() now automatically logs detailed error messages on
failure. This eliminates the need for driver-specific dev_err() and
dev_err_probe() calls that previously printed generic messages.

Signed-off-by: Pan Chuang <redacted>
---
 drivers/dma/stm32/stm32-dma.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/dma/stm32/stm32-dma.c b/drivers/dma/stm32/stm32-dma.c
index d3ad78562a14..51cb2328a8e1 100644
--- a/drivers/dma/stm32/stm32-dma.c
+++ b/drivers/dma/stm32/stm32-dma.c
@@ -1669,12 +1669,8 @@ static int stm32_dma_probe(struct platform_device *pdev)
 		ret = devm_request_irq(&pdev->dev, chan->irq,
 				       stm32_dma_chan_irq, 0,
 				       dev_name(chan2dev(chan)), chan);
-		if (ret) {
-			dev_err(&pdev->dev,
-				"request_irq failed with err %d channel %d\n",
-				ret, i);
+		if (ret)
 			goto err_unregister;
-		}
 	}
 
 	ret = of_dma_controller_register(pdev->dev.of_node,
-- 
2.34.1

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help