Thread (1 message) 1 message, 1 author, 12d ago
COOLING6d

[PATCH 08/26] dmaengine: owl-dma: Remove redundant dev_err()/dev_err_probe()

From: Pan Chuang <hidden>
Date: 2026-07-09 13:59:22
Also in: dmaengine, lkml
Subsystem: arm/actions semi architecture, dma generic offload engine subsystem, the rest · Maintainers: Andreas Färber, Manivannan Sadhasivam, Vinod Koul, Linus Torvalds

The devm_request_irq() now automatically logs detailed error messages on
failure. This eliminates the need for driver-specific dev_err() and
dev_err_probe() calls that previously printed generic messages.

Signed-off-by: Pan Chuang <redacted>
---
 drivers/dma/owl-dma.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c
index 7c80572fc71d..71d0b15968c6 100644
--- a/drivers/dma/owl-dma.c
+++ b/drivers/dma/owl-dma.c
@@ -1163,10 +1163,8 @@ static int owl_dma_probe(struct platform_device *pdev)
 	od->irq = platform_get_irq(pdev, 0);
 	ret = devm_request_irq(&pdev->dev, od->irq, owl_dma_interrupt, 0,
 			       dev_name(&pdev->dev), od);
-	if (ret) {
-		dev_err(&pdev->dev, "unable to request IRQ\n");
+	if (ret)
 		return ret;
-	}
 
 	/* Init physical channel */
 	od->pchans = devm_kcalloc(&pdev->dev, od->nr_pchans,
-- 
2.34.1

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help