Thread (1 message) 1 message, 1 author, 5d ago

Re: [PATCH v14 0/7] Provide support for Trigger Generation Unit

From: Songwei.Chai <hidden>
Date: 2026-07-01 06:08:31
Also in: linux-arm-msm, linux-devicetree, lkml

On 6/30/2026 3:59 PM, Songwei.Chai wrote:

On 6/29/2026 6:44 PM, Suzuki K Poulose wrote:
quoted
Hello,

On 29/06/2026 11:17, Songwei.Chai wrote:
quoted
On 6/29/2026 12:22 PM, Greg KH wrote:
quoted
On Mon, Jun 29, 2026 at 11:03:33AM +0800, Songwei.Chai wrote:
quoted
Hi Greg & Alexander,

Apologies for interrupting again.

As the TGU hardware plays an important role in Qualcomm tracing 
design, I
would greatly appreciate it if you could kindly take some time to 
review
this at your earliest convenience.
The merge window _just_ closed, please give us a chance to catch up.

Also, why us?  Surely you have other reviewers for this code, right?
Hi Greg,

Understood, thanks for letting us know.

Regarding your question: since this introduces a new 
drivers/hwtracing/ qcom directory, there is no existing maintainer 
for it.
Given your scope (and Alexander's), we believe you are the most 
relevant reviewers.

The reason for creating the qcom directory is as follows:

/We previously tried to upstream this driver under 
drivers/hwtracing/ coresight,/
/but it was not accepted as it is considered Qualcomm-specific and 
not tightly/
/coupled with the CoreSight subsystem. Based on this feedback, we are 
Some clarification here: This device is not CoreSight  so we denied
keeping this under drivers/hwtracing/coresight/ - Not because it is 
Qualcomm specific. We have TPDM, TPDA, TnoC devices under the coresight
subsystem, which are all Qualcomm specific for e.g.

That said, there are other drivers in drivers/hwtracing/ which I usually
merge and push to Greg, after some reviews/acks from the respective
people (e.g., PTT HiSilicon PCIe Tune and Trace).

But, your proposal was that there were other maintainers for your new 
subtree and you were going to push this via ,linux-arm-msm ? to which I
didn't have any objections.

That said, I am fine with pushing this to Greg via the CoreSight pull
requests (similar to Hisilicon PTT driver), but would need someone to
Maintain/Review the driver (with entries in MAINTAINERS, similar to
PTT).


Thoughts ?
Hi Suzuki,

Thank you for your constructive feedback in helping us move this patch 
forward.
As the owner of this driver, together with Jie Gan (who has extensive 
review experience), we will be responsible for the maintenance and 
review going forward.
I will also include the MAINTAINERS update in the next TGU release.

Please feel free to share any further comments or suggestions.

Thanks,
Songwei
Hi Suzuki,

In the latest TGU Patch series (V15), I have also added you as a 
maintainer so that you will be notified of any new drivers under 
drivers/hwtracing/qcom.

The review responsibilities will be handled by Jie and myself.

Thanks,

Songwei
quoted
Kind regards
Suzuki


quoted
exploring/
/a dedicated drivers/hwtracing/qcom directory, similar to intel_th, 
to better/
/support this and future Qualcomm hwtracing drivers./

More details can be found in “[PATCH v14 0/7] -- Why we are 
proposing this”.

Thanks,
Songwei
quoted
thanks,

greg k-h
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help