Thread (2 messages) 2 messages, 2 authors, 2026-06-17
COLD34d

[PATCH] nvmem: rockchip-otp: initialize ret in rk3588_otp_read

From: Ruoyu Wang <hidden>
Date: 2026-06-17 18:38:19
Also in: linux-rockchip, lkml
Subsystem: arm/rockchip soc support, nvmem framework, the rest · Maintainers: Heiko Stuebner, Srinivas Kandagatla, Linus Torvalds

rk3588_otp_read() returns ret after a count-controlled loop. If count is
zero, the loop is skipped and ret is not assigned. Initialize ret to 0
for the empty read path.

Signed-off-by: Ruoyu Wang <redacted>
---
 drivers/nvmem/rockchip-otp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvmem/rockchip-otp.c b/drivers/nvmem/rockchip-otp.c
index 0ec78b5e19e7d..50a19b6dc4027 100644
--- a/drivers/nvmem/rockchip-otp.c
+++ b/drivers/nvmem/rockchip-otp.c
@@ -242,7 +242,7 @@ static int rk3588_otp_read(void *context, unsigned int offset,
 {
 	struct rockchip_otp *otp = context;
 	u32 *buf = val;
-	int ret;
+	int ret = 0;
 
 	while (count--) {
 		writel((offset++ << RK3588_ADDR_SHIFT) |
-- 
2.51.0

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help