Thread (20 messages) 20 messages, 5 authors, 21d ago

Re: [PATCH v2 03/12] drm/bridge: synopsys: dw-dp: Simplify driver data setting

From: Andy Yan <andy.yan@rock-chips.com>
Date: 2026-06-04 11:32:39
Also in: dri-devel, linux-devicetree, linux-rockchip, lkml

Hello,

On 5/1/26 06:20, Sebastian Reichel wrote:
There is no need to get the platform device just for setting up
the driver data. Simplify the logic.

Signed-off-by: Sebastian Reichel <redacted>
    Reviewed-by: Andy Yan [off-list ref]
quoted hunk ↗ jump to hunk
---
  drivers/gpu/drm/rockchip/dw_dp-rockchip.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c b/drivers/gpu/drm/rockchip/dw_dp-rockchip.c
index 150c2da8fee5..52e956bffb12 100644
--- a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw_dp-rockchip.c
@@ -74,7 +74,6 @@ static const struct drm_encoder_helper_funcs dw_dp_encoder_helper_funcs = {
  
  static int dw_dp_rockchip_bind(struct device *dev, struct device *master, void *data)
  {
-	struct platform_device *pdev = to_platform_device(dev);
  	const struct dw_dp_plat_data *plat_data;
  	struct drm_device *drm_dev = data;
  	struct rockchip_dw_dp *dp;
@@ -87,7 +86,7 @@ static int dw_dp_rockchip_bind(struct device *dev, struct device *master, void *
  		return -ENOMEM;
  
  	dp->dev = dev;
-	platform_set_drvdata(pdev, dp);
+	dev_set_drvdata(dev, dp);
  
  	plat_data = of_device_get_match_data(dev);
  	if (!plat_data)
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help