Re: [PATCH v9 03/23] perf tests: Sort includes and add missed explicit dependencies
From: Namhyung Kim <namhyung@kernel.org>
Date: 2026-05-26 00:35:26
Also in:
linux-perf-users, lkml
On Fri, May 22, 2026 at 03:04:14PM -0700, Ian Rogers wrote:
Fix missing #includes found while cleaning the evsel/evlist header files. Sort the remaining header files for consistency with the rest of the code. Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org> Thanks, Namhyung
quoted hunk ↗ jump to hunk
--- tools/perf/tests/hwmon_pmu.c | 14 +++++++++----- tools/perf/tests/mmap-basic.c | 18 +++++++++++------- 2 files changed, 20 insertions(+), 12 deletions(-)diff --git a/tools/perf/tests/hwmon_pmu.c b/tools/perf/tests/hwmon_pmu.c index 4aa4aac94f09..ada6e445c4c4 100644 --- a/tools/perf/tests/hwmon_pmu.c +++ b/tools/perf/tests/hwmon_pmu.c@@ -1,15 +1,19 @@ // SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) -#include "debug.h" -#include "evlist.h" #include "hwmon_pmu.h" -#include "parse-events.h" -#include "tests.h" + #include <errno.h> + #include <fcntl.h> -#include <sys/stat.h> #include <linux/compiler.h> #include <linux/kernel.h> #include <linux/string.h> +#include <sys/stat.h> + +#include "debug.h" +#include "evlist.h" +#include "parse-events.h" +#include "pmus.h" +#include "tests.h" static const struct test_event { const char *name;diff --git a/tools/perf/tests/mmap-basic.c b/tools/perf/tests/mmap-basic.c index a18d84d858aa..a69cd1046e9a 100644 --- a/tools/perf/tests/mmap-basic.c +++ b/tools/perf/tests/mmap-basic.c@@ -1,25 +1,29 @@ // SPDX-License-Identifier: GPL-2.0 #include <errno.h> -#include <fcntl.h> #include <inttypes.h> #include <stdlib.h> + +#include <fcntl.h> +#include <linux/err.h> +#include <linux/kernel.h> +#include <linux/string.h> + #include <perf/cpumap.h> +#include <perf/evlist.h> +#include <perf/mmap.h> #include "cpumap.h" #include "debug.h" #include "event.h" #include "evlist.h" #include "evsel.h" -#include "thread_map.h" +#include "pmu.h" +#include "pmus.h" #include "tests.h" +#include "thread_map.h" #include "util/affinity.h" #include "util/mmap.h" #include "util/sample.h" -#include <linux/err.h> -#include <linux/kernel.h> -#include <linux/string.h> -#include <perf/evlist.h> -#include <perf/mmap.h> /* * This test will generate random numbers of calls to some getpid syscalls,-- 2.54.0.794.g4f17f83d09-goog