On 25-05-2026 13:41, Dmitry Baryshkov wrote:
On Mon, May 25, 2026 at 11:59:33AM +0530, Kuldeep Singh wrote:
quoted
quoted
This driver is more than an order of magnitude slower than the CPU for
both encryption and hashing. See:
https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@kernel.org/ (local)
https://lore.kernel.org/r/20250615031807.GA81869@sol/ (local)
There are many examples of it having bugs as well, for example see the
second link above.
That's why it had to be disabled via the cra_priority system. This
driver was actively making Linux worse.
This isn't particularly unique to drivers/crypto/, of course. This one
we just have data on, so it's a bit clearer.
I've yet to see any real reason to keep this driver.
https://lore.kernel.org/all/c1697372-54ec-4f57-85d9-ad375ff1a44d@oss.qualcomm.com/ (local)
Kindly check my latest reply to the thread. There are numerous usecases
like DRM(Digital rights management) coming up and qce driver is required
for secure content.
quoted
Crypto drivers need to be held to a higher standard than other device
drivers, as well. The onus is on those who want to keep a particular
crypto driver to prove that it's worth keeping.
Sure, I'll be working on stabilizing self_tests infra for qce.
Kindly allow sometime to go over failures in crypto selftest and will
submit fix if applicable.
Why are not selftests a part of your default config? How are you testing
the driver?
We are validating the driver probe and kcapi userspace tests while
validating qce algos. Locally we update all 3 algo priority and then run
kcapi_convinience.sh test suite to ensure it picks qce algos.
Please note, previously were not aware need to run selftests suite too.
Got to know about this once issue was reported.
quoted
So far, i am observing 2 ciphers failing(xts-aes-qce and ctr-aes-qce )
with CONFIG_CRYPTO_SELFTESTS enabled.
Please make sure to run the tests on older platforms too, not just the
latest & greatest.
Yes, will check on all the platforms.
--
Regards
Kuldeep