Re: [PATCH v2 1/3] clk: nuvoton: ma35d1: fix ignored div_u64 return values in PLL freq calculation
From: Brian Masney <bmasney@redhat.com>
Date: 2026-05-19 14:52:03
Also in:
linux-clk, lkml
On Wed, May 13, 2026 at 01:56:24PM +0800, Joey Lu wrote:
div_u64() does not modify its argument in place; the return value must
be assigned. Both ma35d1_calc_smic_pll_freq() and ma35d1_calc_pll_freq()
called div_u64() and discarded the result, leaving pll_freq holding the
undivided product and thus returning a frequency orders of magnitude too
high.
Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock controller")
Signed-off-by: Joey Lu <redacted>Reviewed-by: Brian Masney <bmasney@redhat.com>