Re: [PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2026-03-01 13:39:39
Also in:
linux-arm-msm, linux-phy, netdev
On Sat, Feb 28, 2026 at 08:31:11AM -0800, Jakub Kicinski wrote:
On Fri, 27 Feb 2026 16:55:56 -0800 Jakub Kicinski wrote:quoted
On Sat, 28 Feb 2026 00:11:29 +0000 Russell King (Oracle) wrote:quoted
The AI review for patch 7 says: This commit fixes a bug but lacks a Fixes: tag. The commit modifies behavior introduced in 360000820ae2 ("phy: qcom-sgmii-eth: add .set_mode() and .validate() methods") by making phy_power_on() call qcom_dwmac_sgmii_phy_calibrate() to restore the previous setup, and by making qcom_dwmac_sgmii_phy_set_mode() check if the PHY is powered on before attempting calibration. Should this commit include: Fixes: 360000820ae2 ("phy: qcom-sgmii-eth: add .set_mode() and .validate() methods") which is _wrong_, this isn't a bug fix.Yes, that's what I thought but then I saw the other thread..Trying to apply this now but stmmac parts don't apply on Linus's tree, and Vinod wants a tag :( What do we do?
The problem will be that this series has dependencies on the first
batch of qcom-ethqos patches, particularly:
cd0aa6515350 ("net: stmmac: pass interface mode into fix_mac_speed()
method")
b560938163db ("net: stmmac: qcom-ethqos: pass phy interface mode to
configs")
fb42f19e671f ("net: stmmac: qcom-ethqos: move SerDes speed
configuration")
which enables the change in the third patch of this series - and
without the third patch, none of the following patches in this series
can be applied.
I'm not sure what to suggest either.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!