On Thu, Mar 26, 2026 at 12:55 AM Mark Brown [off-list ref] wrote:

On Wed, Mar 25, 2026 at 09:56:00AM +0100, Krzysztof Kozlowski wrote:

quoted

On Tue, Mar 24, 2026 at 01:30:28PM +0800, Chen-Yu Tsai wrote:

quoted

quoted

+      pvdd4-supply:
+        description: Supply for vbuck4

quoted

These all look per-regulator supplies, so I think they should be in each
regulator node (see also regulator.yaml).

quoted

Or in top-level, but not in "regulators" node. The regulators is only
wrapping node for children.

quoted

I wonder what should be our preference - have supplies per regulator or
in top-level node. @Mark, any preference from your side?

The top level, so people can figure out where to describe supplies
without having to read the bindings so much - the supplies go into the
chip, even if they're distributed within it.

OK. What about the more complicated mfd PMICs? We already added
*-supplies for the regulator side of these PMICs in

  - regulator/mediatek,mt6358-regulator.yaml
  - regulator/mediatek,mt6363-regulator.yaml

And my other series for the MT6359 also adds them in this manner.


Thanks
ChenYu