Re: [PATCH v5 1/3] dt-bindings: media: mediatek-jpeg-decoder: add MT8189 compatible string
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-03-31 06:58:13
Also in:
linux-devicetree, linux-media, linux-mediatek, lkml
On Tue, Mar 31, 2026 at 08:54:56AM +0800, Jianhua Lin wrote:
quoted hunk ↗ jump to hunk
Add the compatible string for the JPEG decoder block found in the MediaTek MT8189 SoC. Compared to previous generation ICs, the MT8189 JPEG decoder requires 34-bit IOVA address space support and only needs a single clock ("jpgdec") instead of two. Therefore, it is added as a standalone compatible string without falling back to older SoCs. Update the binding schema to include the new compatible string and add an `allOf` block with conditional checks. This enforces the single clock requirement for MT8189 while preserving the two-clock requirement ("jpgdec-smi", "jpgdec") for older SoCs. Suggested-by: Rob Herring <robh@kernel.org> Signed-off-by: Jianhua Lin <redacted> --- .../bindings/media/mediatek-jpeg-decoder.yaml | 44 +++++++++++++++---- 1 file changed, 36 insertions(+), 8 deletions(-)diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml index a4aacd3eb189..601fe05b73e7 100644 --- a/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml@@ -15,10 +15,10 @@ description: |- properties: compatible: oneOf: - - items: - - enum: - - mediatek,mt8173-jpgdec - - mediatek,mt2701-jpgdec + - enum: + - mediatek,mt2701-jpgdec + - mediatek,mt8173-jpgdec + - mediatek,mt8189-jpgdec - items: - enum: - mediatek,mt7623-jpgdec@@ -32,13 +32,22 @@ properties: maxItems: 1 clocks: + minItems: 1 maxItems: 2 - minItems: 2 clock-names: - items: - - const: jpgdec-smi - - const: jpgdec + minItems: 1 + maxItems: 2
Why jpgdec-smi alone is now valid? Drop these two.
+ oneOf: + - items: + - const: jpgdec + - items: + - const: jpgdec-smi + - const: jpgdec + + mediatek,larb: + $ref: /schemas/types.yaml#/definitions/phandle + description: a phandle to the smi_larb node.
Best regards, Krzysztof