Re: [PATCH v5 6/9] arm64: dts: amlogic: t7: khadas-vim4: Add power regulators
From: Neil Armstrong <neil.armstrong@linaro.org>
Date: 2026-03-30 07:55:31
Also in:
linux-amlogic, linux-devicetree, linux-mmc, linux-wireless, lkml
On 3/26/26 10:59, Ronald Claveau wrote:
quoted hunk ↗ jump to hunk
Add voltage regulator nodes describing the VIM4 power tree, required by peripheral nodes such as the SD card controller. Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Ronald Claveau <redacted> --- .../dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts | 90 ++++++++++++++++++++++ 1 file changed, 90 insertions(+)diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts index fffdab96b12eb..2450084d37642 100644 --- a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts@@ -6,6 +6,8 @@ /dts-v1/; #include "amlogic-t7.dtsi" +#include <dt-bindings/gpio/amlogic,t7-periphs-pinctrl.h> +#include <dt-bindings/gpio/gpio.h> / { model = "Khadas vim4";@@ -45,6 +47,94 @@ xtal: xtal-clk { #clock-cells = <0>; }; + dc_in: regulator-dc-in { + compatible = "regulator-fixed"; + regulator-name = "DC_IN"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + }; + + sd_3v3: regulator-sdcard-3v3 { + compatible = "regulator-fixed"; + regulator-name = "SD_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + vin-supply = <&vddao_3v3>; + gpio = <&gpio GPIOD_11 GPIO_ACTIVE_LOW>; + regulator-boot-on;
+ enable-active-low;
This properly is invalid, please send follow up patch removing this, Thanks, Neil <snip>