On Fri, Mar 27, 2026 at 3:08 PM Lorenzo Pieralisi [off-list ref] wrote:

On Fri, Mar 06, 2026 at 02:32:46PM +0100, Bartosz Golaszewski wrote:

quoted

On Thu, Mar 5, 2026 at 6:07 PM Shivendra Pratap
[off-list ref] wrote:

quoted

quoted

You should pass the address of this function in faux_device_ops instead of
calling it directly.

In last patch, we were using a probe function. As faux_device_create,
calls the probe from its internal operations, "of_node" can only be
assigned from inside of faux device probe.

As our primary requirement is to assign reboot-mode of_node to the faux
device, thought to make it this way. (As we did not want to assign it
inside the faux device probe).

TBH This sounds like a limitation of the faux device API. I'll Cc you
on a patch proposing to extend it with the ability of using a firmware
node to describe the device. If it works for you, you can integrate it
into your series and use it.

What's the status on this matter ?

I looked around and didn't find any good reason for adding this after
all so I dropped it.

Bart