Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for S6 S7 S7D
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-03-27 08:25:27
Also in:
linux-amlogic, linux-devicetree, linux-pwm, lkml
On Thu, Mar 26, 2026 at 06:35:38AM +0000, Xianwei Zhao wrote:
quoted hunk ↗ jump to hunk
+ - items: + - enum: + - amlogic,s6-pwm + - amlogic,s7d-pwm + - const: amlogic,s7-pwm - items: - enum: - amlogic,meson8b-pwm-v2@@ -146,6 +152,20 @@ allOf: clock-names: false required: - clocks + - if: + properties: + compatible: + contains: + enum: + - amlogic,s7-pwm + then: + properties: + clocks: + items: + - description: input clock of PWM
so simpler: "maxItems: 1"
quoted hunk ↗ jump to hunk
+ clock-names: false + required: + - clocks - if: properties:@@ -182,3 +202,10 @@ examples: clocks = <&pwm_src_a>, <&pwm_src_b>; #pwm-cells = <3>; }; + - | + pwm@1000 { + compatible = "amlogic,s7-pwm";
You already have three examples, don't add more. With these changes: Reviewed-by: Krzysztof Kozlowski <redacted> Best regards, Krzysztof