Re: [PATCH] media: verisilicon: AV1: Discard none supported profiles
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date: 2026-03-25 18:46:54
Also in:
linux-media, linux-rockchip, lkml
Le mercredi 25 mars 2026 à 14:19 +0100, Benjamin Gaignard a écrit :
quoted hunk ↗ jump to hunk
AV1 hardware can only decode YUV420 pixel format. That means that only profile 0 is supported. Discard all other profiles when receiving AV1 sequence control. Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> --- drivers/media/platform/verisilicon/hantro_drv.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/media/platform/verisilicon/hantro_drv.c b/drivers/media/platform/verisilicon/hantro_drv.c index 2e81877f640f..12f98e7e7994 100644 --- a/drivers/media/platform/verisilicon/hantro_drv.c +++ b/drivers/media/platform/verisilicon/hantro_drv.c@@ -283,6 +283,8 @@ static int hantro_try_ctrl(struct v4l2_ctrl *ctrl)if (sequence->bit_depth != 8 && sequence->bit_depth != 10) return -EINVAL; + if (sequence->seq_profile != 0) + return -EINVAL;
You should also add the missing control to better tell userspace what it can and
cannot do. Check MTK driver for reference, I think the same config can be used:
drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
...
.cfg = {
.id = V4L2_CID_MPEG_VIDEO_AV1_PROFILE,
.min = V4L2_MPEG_VIDEO_AV1_PROFILE_MAIN,
.def = V4L2_MPEG_VIDEO_AV1_PROFILE_MAIN,
.max = V4L2_MPEG_VIDEO_AV1_PROFILE_MAIN,
},
...
Nicolas
} return 0;
Attachments
- signature.asc [application/pgp-signature] 228 bytes