Thread (11 messages) 11 messages, 3 authors, 2026-03-25

Re: [PATCH v2 2/6] arm64: dts: freescale: Add Verdin iMX95 support

From: Frank Li <Frank.li@nxp.com>
Date: 2026-03-25 15:01:28
Also in: imx, linux-devicetree, lkml

On Wed, Mar 25, 2026 at 12:27:24PM +0100, Francesco Dolcini wrote:
On Tue, Mar 24, 2026 at 12:14:35PM -0400, Frank Li wrote:
quoted
On Fri, Mar 13, 2026 at 09:57:43AM +0100, Ernest Van Hoecke wrote:
quoted
From: Ernest Van Hoecke <redacted>

Add support for the Toradex Verdin iMX95 and its development carrier
board.

The module consists of an NXP i.MX95 family SoC, up to 16GB LPDDR4x RAM,
up to 128GB of storage, a USB 3.2 OTG and USB 2.0 Host, a Gigabit
Ethernet PHY, an I2C EEPROM and Temperature Sensor, an RX8130 RTC, an
I3C bus, one Quad lane CSI interface, one Quad lane DSI or CSI
interface, one LVDS interface (one or two channels), and some optional
addons: TPM 2.0, and a WiFi/BT module.

Link: https://www.toradex.com/computer-on-modules/verdin-arm-family/nxp-imx95
Link: https://www.toradex.com/products/carrier-board/verdin-development-board-kit
Co-developed-by: Emanuele Ghidoli <redacted>
Signed-off-by: Emanuele Ghidoli <redacted>
Co-developed-by: Francesco Dolcini <redacted>
Signed-off-by: Francesco Dolcini <redacted>
Signed-off-by: Ernest Van Hoecke <redacted>
---
v2: Reordered nodes alphanumerically by node name
v1: https://lore.kernel.org/all/20260305-verdin-imx95-upstream-frank-li-base-v1-2-823fad02def9@toradex.com/ (local)
---
+
+/* Verdin UART_1, connector X50 through RS485 transceiver */
+&lpuart7 {
+	rs485-rts-active-low;
+	rs485-rx-during-tx;
+	linux,rs485-enabled-at-boot-time;
+
Nit: needn't empty line between status and other property, suggest run
https://github.com/lznuaa/dt-format to speed up process.
Please review Documentation/devicetree/bindings/dts-coding-style.rst.

Quoting from there
 > "status" (if applicable), preceded by a blank line if there is content before the property

I would be careful on taking every detail of such a style guide literally,
but your comment here is not correct and it's not helping anyone.
Thank you point out,  there are not extra empty line in existing dts.
git grep -r -a3 "status =" arch/arm64/boot/dts/

I think it should update dts-coding-style.rst to match most existing one.

Frank
Francesco
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help