On Tue, Mar 24, 2026 at 06:39:10PM +0100, Marek Vasut wrote:

On 3/24/26 5:01 PM, Frank Li wrote:

quoted

On Fri, Mar 13, 2026 at 12:24:04AM +0100, Marek Vasut wrote:
...

quoted

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-overlay-panel-ch101olhlwh.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-overlay-panel-ch101olhlwh.dtsi
new file mode 100644
index 0000000000000..534737363c9f0
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-overlay-panel-ch101olhlwh.dtsi

@@ -0,0 +1,42 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2022 Marek Vasut

2026?

That was the original copyright year when this was implemented, but I can
update it to 2022-2026 ?

Okay, you upstream this year.

quoted

quoted

+ */
+
+&display_bl {
+	pwms = <&pwm1 0 5000000 0>;
+};
+
+&DH_OVERLAY_PANEL_I2C_BUS {

why upcase for label, generally it should be lower case

Because this label is really a macro , please read on.

quoted

quoted

+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	touchscreen@41 {
+		compatible = "ilitek,ili251x";
+		pinctrl-0 = <DH_OVERLAY_PANEL_I2C_TOUCHSCREEN_PINCTRL>;
+		pinctrl-names = "default";
+		reg = <0x41>;

reg should second property,  please dt-format for new dts files.
check others

What is "dt-format" ? Linux kernel source tree, even current next, does not
mention such a tool . I did run schema check and checkpatch on these
patches. obv.

I send out at many place, https://github.com/lznuaa/dt-format
I write small tools to detect and fix node and property order problem,
it may be buggy.

These node order problem is easy to detected and fix by tools to save
review cycle and focus on the important stuff.

Frank

quoted

quoted

+		interrupt-parent = <&DH_OVERLAY_PANEL_I2C_TOUCHSCREEN_IRQ_PARENT>;

...

quoted

+
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		port@1 {
+			reg = <1>;

need empty line between child node and property.

Fixed in V2

quoted

quoted

+	#size-cells = <0>;
+
+	eeprom@56 {
+		compatible = "atmel,24c04";
+		reg = <0x56>;
+		pagesize = <16>;
+	};
+};
+
+&ecspi2 {
+	status = "okay";

status should be last property. I stop here because these
should be identify by tools/script

Neither checkpatch nor schema validation complained about these.

I moved the status=okay to the end. Anything else I should update ?