Re: [PATCH v5 0/3] dmaengine: arm-dma350: support combined IRQ mode with runtime IRQ topology detection

On 2026-03-24 12:01 pm, Jun Guo wrote:

DMA-350 can be integrated with either one interrupt per channel or a
single combined interrupt for all channels. This series adds support
for the combined IRQ topology while keeping compatibility with the
per-channel topology.

Patch 1 updates the DT binding to describe both interrupt topologies
(1 combined IRQ or 8 per-channel IRQs).

Patch 2 updates the driver to detect IRQ topology at runtime via
platform_irq_count(), handle both modes in one code path, and enable
DMANSECCTRL.INTREN_ANYCHINTR only in combined IRQ mode.

Patch 3 adds the Sky1 DMA DT node using the combined IRQ topology.

Tested on CIX SKY1 with dmatest:
   % echo 2000 > /sys/module/dmatest/parameters/timeout
   % echo 1 > /sys/module/dmatest/parameters/iterations
   % echo "" > /sys/module/dmatest/parameters/channel
   % echo 1 > /sys/module/dmatest/parameters/run

Changes in v5:
- Fix the formatting issue in the AI tag.
- Remove the unnecessary "cix,sky1-dma-350".

Please don't churn reposts of a series so quickly. I've only just had 
time to finish the review of v3 that you posted only 3 working days ago, 
that I already moved over as a reply to yesterday's v4 for visibility...

Thanks,
Robin.

Changes in v4:
- Reword binding text to align with kernel style.
- Revise the AI attribution to the standard format.
- Remove redundant links from the commit log.

Changes in v3:
- Rework binding compatible description to match generic-first model.
- Keep interrupts schema support for both 1-IRQ and 8-IRQ topologies.
- Drop SoC match-data dependency for IRQ mode selection.
- Detect IRQ topology via platform_irq_count() in probe path.
- Refactor IRQ handling into a shared channel handler.
- Enable DMANSECCTRL.INTREN_ANYCHINTR only in combined IRQ mode.

Changes in v2:
- Update to kernel standards, enhance patch description, and refactor
  driver to use match data for hardware differentiation instead of
  compatible strings.

Jun Guo (3):
   dt-bindings: dma: arm-dma350: document combined and per-channel IRQ
     topologies
   dma: arm-dma350: support combined IRQ mode with runtime IRQ topology
     detection
   arm64: dts: cix: add DT nodes for DMA

  .../devicetree/bindings/dma/arm,dma-350.yaml  |  25 ++-
  arch/arm64/boot/dts/cix/sky1.dtsi             |   7 +
  drivers/dma/arm-dma350.c                      | 164 +++++++++++++++---
  3 files changed, 161 insertions(+), 35 deletions(-)