Re: [PATCH v5 15/17] spi: uniphier: Simplify clock handling with devm_clk_get_enabled()
From: Mark Brown <broonie@kernel.org>
Date: 2026-03-23 21:49:35
Also in:
imx, linux-mediatek, linux-riscv, linux-rockchip, linux-spi, lkml, openbmc
On Thu, Mar 19, 2026 at 10:04:11AM +0800, Pei Xiao wrote:
Replace devm_clk_get() followed by clk_prepare_enable() with devm_clk_get_enabled() for the clock. This removes the need for explicit clock enable and disable calls, as the managed API automatically handles clock disabling on device removal or probe failure.
This breaks an allmodconfig build:
/build/stage/linux/drivers/spi/spi-uniphier.c: In function ‘uniphier_spi_remove’
:
/build/stage/linux/drivers/spi/spi-uniphier.c:773:35: error: unused variable ‘pr
iv’ [-Werror=unused-variable]
773 | struct uniphier_spi_priv *priv = spi_controller_get_devdata(host
);
| ^~~~ Attachments
- signature.asc [application/pgp-signature] 488 bytes