Re: [PATCH v8 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-03-21 19:14:42
Also in:
linux-devicetree, linux-pm, linux-samsung-soc, lkml
On 18/03/2026 16:27, André Draszik wrote:
quoted hunk ↗ jump to hunk
The power domains are a property of / implemented in the PMU. As such, they should be modelled as child nodes of the PMU. Note: Because the properties added are 'required', this commit breaks DT validation of the existing DT for Pixel 6, but a) that's simply because the DT is incomplete and b) a DT update will be posted once the binding is accepted. It is not possible to write the binding such that it supports old (incomplete) DTs in addition to the full version, but as per above it's not required to keep supporting old DTs. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- v8: - move comment from commit message footer into body (Rob) - fix incorrect use of ranges in example (Rob) v7: - really be consistent with quoting (Krzysztof) - drop invalid tested-by tag (Krzysztof) v4: - consistent quoting using " (Krzysztof) - add samsung,dtzpc to example --- .../bindings/soc/google/google,gs101-pmu.yaml | 41 ++++++++++++++++++++++ 1 file changed, 41 insertions(+)diff --git a/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml b/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml index a06bd8ec3c20..52c47252b801 100644 --- a/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml +++ b/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml@@ -16,6 +16,14 @@ properties: reg: maxItems: 1 + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + + ranges: true + reboot-mode: $ref: /schemas/power/reset/syscon-reboot-mode.yaml type: object@@ -39,9 +47,23 @@ properties: description: Phandle to PMU interrupt generation interface. +patternProperties: + "^power-domain@[0-9a-f]+$": + type: object + description: Child node describing one power domain within the PMU + + additionalProperties: true + + properties: + compatible: + const: google,gs101-pd + required: - compatible - reg + - "#address-cells" + - "#size-cells" + - ranges
This causes warnings, so I dropped the patches. I really do not understand how this is organized. This is not a dependency for pm domains driver but it is included here. It is a soft dependency for DTS, but that is nowhere to be found. Best regards, Krzysztof