Re: [PATCH v4 2/5] drm/meson: handle RGB101010 in format switches
From: Dmitry Baryshkov <hidden>
Date: 2026-03-21 17:16:47
Also in:
dri-devel, linux-amlogic, linux-arm-msm, lkml
On Sat, Mar 21, 2026 at 07:52:30AM +0000, Alexander Koskovich wrote:
quoted hunk ↗ jump to hunk
Add RGB101010 to the unsupported format cases to fix -Wswitch warnings introduced by the addition of the new pixel format. Signed-off-by: Alexander Koskovich <redacted> --- drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c index 66c73c512b0e..59fc0083d318 100644 --- a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c +++ b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c@@ -119,6 +119,7 @@ static int dw_mipi_dsi_phy_init(void *priv_data) dpi_data_format = DPI_COLOR_18BIT_CFG_2; venc_data_width = VENC_IN_COLOR_18B; break; + case MIPI_DSI_FMT_RGB101010: case MIPI_DSI_FMT_RGB666_PACKED: case MIPI_DSI_FMT_RGB565:
This would need to be changed again and again as we add more pixel formats supported by the MIPI DSI panels. I think it would make more sense to use 'default:' here instead of listing all of them here.
quoted hunk ↗ jump to hunk
return -EINVAL;@@ -232,6 +233,7 @@ static int meson_dw_mipi_dsi_host_attach(void *priv_data, break; case MIPI_DSI_FMT_RGB666: break; + case MIPI_DSI_FMT_RGB101010: case MIPI_DSI_FMT_RGB666_PACKED: case MIPI_DSI_FMT_RGB565:
And here
dev_err(mipi_dsi->dev, "invalid pixel format %d\n", device->format); -- 2.53.0
-- With best wishes Dmitry