Re: [PATCH v4 5/7] arm_scmi: pinctrl: allow PINCTRL_REQUEST to return EOPNOTSUPP
From: Cristian Marussi <cristian.marussi@arm.com>
Date: 2026-03-18 11:08:00
Also in:
arm-scmi, linux-gpio, lkml
On Tue, Mar 17, 2026 at 05:40:50PM +0300, Dan Carpenter wrote:
The SCMI protocol specification says that the PINCTRL_REQUEST and PINCTRL_RELEASE commands are optional. So if the SCMI server returns -EOPNOTSUPP, then treat that as success and continue.
Hi a nitpick, this should be firmware: arm_scmi: Allow PINCTRL_REQUEST to return EOPNOTSUPP Thanks, Cristian
quoted hunk ↗ jump to hunk
Signed-off-by: Dan Carpenter <redacted> Reviewed-by: Linus Walleij <linusw@kernel.org> Reviewed-by: Sudeep Holla <sudeep.holla@kernel.org> --- drivers/firmware/arm_scmi/pinctrl.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/firmware/arm_scmi/pinctrl.c b/drivers/firmware/arm_scmi/pinctrl.c index a020e23d7c49..42cb1aef1fe1 100644 --- a/drivers/firmware/arm_scmi/pinctrl.c +++ b/drivers/firmware/arm_scmi/pinctrl.c@@ -578,6 +578,8 @@ static int scmi_pinctrl_request_free(const struct scmi_protocol_handle *ph, tx->flags = cpu_to_le32(type); ret = ph->xops->do_xfer(ph, t); + if (ret == -EOPNOTSUPP) + ret = 0; ph->xops->xfer_put(ph, t); return ret;-- 2.51.0