Re: [PATCH v2 7/8] firmware: smccc: lfa: Register DT interrupt
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-03-18 08:14:16
Also in:
linux-devicetree, lkml
On Tue, Mar 17, 2026 at 11:33:33AM +0100, Andre Przywara wrote:
quoted hunk ↗ jump to hunk
+ return devm_request_threaded_irq(dev, irq, lfa_irq_handler, + lfa_irq_handler_thread, + IRQF_COND_ONESHOT, NULL, NULL); +} + static int lfa_faux_probe(struct faux_device *fdev) { int ret;@@ -854,6 +893,12 @@ static int lfa_faux_probe(struct faux_device *fdev) } } + ret = lfa_register_dt(&fdev->dev); + if (!ret) + pr_info("registered LFA DT notification interrupt\n");
Drop. Drivers must be silent on success (mentioned more than once in coding docs). Starting FW update would deserve a comment, but probing a device or its resource is completely irrelevant for the user.
+ if (ret != -ENODEV) + return ret; + return 0; } -- 2.43.0