Re: [PATCH] dwc3: google: Fix PM domain leak in dwc3_google_probe()
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Date: 2026-03-18 01:15:02
Also in:
linux-samsung-soc, linux-usb, lkml
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Date: 2026-03-18 01:15:02
Also in:
linux-samsung-soc, linux-usb, lkml
On Mon, Mar 16, 2026, Felix Gu wrote:
When syscon_regmap_lookup_by_phandle_args() fails, the function was returning directly without cleaning up the power domain initialized earlier by dwc3_google_pm_domain_init(). Fix by jumping to err_deinit_pdom to properly clean up resources. Fixes: 8995a37371bf4 ("usb: dwc3: Add Google Tensor SoC DWC3 glue driver") Signed-off-by: Felix Gu <redacted> --- drivers/usb/dwc3/dwc3-google.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)diff --git a/drivers/usb/dwc3/dwc3-google.c b/drivers/usb/dwc3/dwc3-google.c index 2105c72af753..4ca567ec01d0 100644 --- a/drivers/usb/dwc3/dwc3-google.c +++ b/drivers/usb/dwc3/dwc3-google.c@@ -385,8 +385,9 @@ static int dwc3_google_probe(struct platform_device *pdev) "google,usb-cfg-csr", ARRAY_SIZE(args), args); if (IS_ERR(google->usb_cfg_regmap)) { - return dev_err_probe(dev, PTR_ERR(google->usb_cfg_regmap), - "invalid usb cfg csr\n"); + ret = dev_err_probe(dev, PTR_ERR(google->usb_cfg_regmap), + "invalid usb cfg csr\n"); + goto err_deinit_pdom; } google->host_cfg_offset = args[0];--- base-commit: b84a0ebe421ca56995ff78b66307667b62b3a900 change-id: 20260316-dwc3-google-fd617b3d19f5 Best regards, -- Felix Gu [off-list ref]
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> BR, Thinh