Thread (27 messages) 27 messages, 3 authors, 2026-03-17

Re: [PATCH V8 06/13] arm: dts: imx6qdl: Add Root Port node and PERST property

From: Manivannan Sadhasivam <mani@kernel.org>
Date: 2026-03-16 05:30:19
Also in: imx, linux-devicetree, linux-pci, lkml

On Fri, Mar 13, 2026 at 02:08:05PM +0800, Chen-Yu Tsai wrote:
On Fri, Mar 13, 2026 at 10:08 AM Sherry Sun [off-list ref] wrote:
quoted
Since describing the PCIe PERST# property under Host Bridge node is now
deprecated, it is recommended to add it to the Root Port node, so
creating the Root Port node and add the reset-gpios property in Root
Port.

Signed-off-by: Sherry Sun <redacted>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-sabresd.dtsi |  5 +++++
 arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi         | 11 +++++++++++
 arch/arm/boot/dts/nxp/imx/imx6qp-sabreauto.dts |  5 +++++
 3 files changed, 21 insertions(+)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-sabresd.dtsi
index ba29720e3f72..fe9046c03ddd 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-sabresd.dtsi
@@ -754,11 +754,16 @@ lvds0_out: endpoint {
 &pcie {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_pcie>;
+       /* This property is deprecated, use reset-gpios from the Root Port node. */
        reset-gpio = <&gpio7 12 GPIO_ACTIVE_LOW>;
I'd say just remove the old description.

You're asking for trouble by describing the same thing in two different places.
quoted
        vpcie-supply = <&reg_pcie>;
I would probably also take this chance to just convert to the proper PCI
slot supply, and just add pwrctrl support into your PCIe driver.
+1

- Mani

-- 
மணிவண்ணன் சதாசிவம்
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help