Re: [PATCH 1/2] dt-bindings: mmc: sdhci-of-aspeed : Add ast2700 support
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-03-14 10:23:16
Also in:
linux-aspeed, linux-devicetree, linux-mmc, lkml, openbmc
On Fri, Mar 13, 2026 at 01:27:56PM +0800, Ryan Chen wrote:
Add the "aspeed,ast2700-sd-controller" compatible. The ast2700 sdhci controller requires an reset, so make the "resets" property mandatory for this compatible to reflect the hardware requirement.
Subject - there is never space before ':'
quoted hunk ↗ jump to hunk
Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> --- Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml index d24950ccea95..a2ff9a94db13 100644 --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml@@ -26,6 +26,7 @@ properties: - aspeed,ast2400-sd-controller - aspeed,ast2500-sd-controller - aspeed,ast2600-sd-controller + - aspeed,ast2700-sd-controller
Missing blank lines everywhere in your patchset.
quoted hunk ↗ jump to hunk
reg: maxItems: 1 description: Common configuration registers@@ -37,6 +38,20 @@ properties: clocks: maxItems: 1 description: The SD/SDIO controller clock gate
Blank line
+ resets: + maxItems: 1
Blank line, just open any other bindings. If this is because you used LLM, then obviously NAK, because we should not waste time to review unsupervised poor quality LLM output. It is your task to review it, not ours.