Re: [PATCH v4 0/3] Add support for Variscite DART-MX91 and Sonata board
From: Stefano Radaelli <hidden>
Date: 2026-03-13 16:56:14
Also in:
imx, linux-devicetree, lkml
Hi Frank, On Fri, Mar 13, 2026 at 12:50:49PM -0400, Frank Li wrote:
On Fri, Mar 13, 2026 at 04:54:42PM +0100, Stefano Radaelli wrote:quoted
Hi Frank, On Fri, Mar 13, 2026 at 11:13:35AM -0400, Frank Li wrote:quoted
Can you rebase to my for-next tree https://git.kernel.org/pub/scm/linux/kernel/git/frank.li/linux.git/log/?h=for-next And new file, run https://github.com/lznuaa/dt-format to keep node nice ordered.Sure, I will rebase the series on top of your for-next branch and send an updated version. If possible, it would be great if the series could be merged as soon as possible, to avoid having to rebase it again on newer changes.I try best. I go though as reverse order patchwork order. https://patchwork.kernel.org/project/imx/list/?series=&submitter=&state=1&q=&archive=&delegate= Small fix go high priority.quoted
Regarding dt-format, I can run it, but in my experience it is a bit buggy.Put bugg in issue list, I will fix it.quoted
It sometimes moves comments to completely unrelated locations and does not always keep a logical ordering of nodes.Logical order is hard to follow. Each one have difference opinion about logic group. I am trying to normalize and machine script. I use same rule for every new dts file. property order is not so important. The key is node orders, which try to avoid add duplicate one in future.quoted
For example, I saw cases where usdhc3_wlan was moved before usdhc3_sleep,quoted
and pinctrl nodes were not kept at the end of the file.About pinctrl nodes at end of the file, we don't stick this rule. There will be more than one pinctrl nodes.
Thank you for the clarification and for the work you are putting into reviewing and maintaining these patches. Regarding dt-format, I will open issues for the cases where I noticed incorrect behavior (such as comments being moved to unrelated sections), so they can be tracked and fixed. Thanks again for your support and for maintaining the i.MX tree. Best regards, Stefano