RE: [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly deprecate reset-gpio

Subject: Re: [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly
deprecate reset-gpio

On 13/03/2026 03:27, Sherry Sun wrote:

quoted

quoted

Subject: [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly
deprecate reset-gpio

The binding references snps,dw-pcie-common.yaml which already
deprecates "reset-gpio", however mentioning this property here lacks
this mark thus code is confusing and suggests property is not deprecated.

OTOH, the property cannot be removed from this schema, because it is
an ABI implemented by Linux kernel in gpiolib-of.c in
backwards-compatible map between compatibles, "reset-gpio" and "reset-

gpio-active-high"

quoted

quoted

properties.

This creates code and binding which is not obvious to follow, so
rewrite it and be more explicit about:
1. Deprecation of "reset-gpio",
2. Relation that "reset-gpio-active-high" is used only for that property
   and not proper "reset-gpios".

Signed-off-by: Krzysztof Kozlowski
[off-list ref]

---

Cc: Sherry Sun <redacted>

Changes in v2:
1. Rewrite the commit completely after Sherry Sun comments - keep the
   property, but add "not" clause to forbid usavge of
   "reset-gpio-active-high" and "reset-gpios".
2. Because of above not adding Richard's ack.

v1:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flor

e.ke%2F&data=05%7C02%7Csherry.sun%40nxp.com%7C6967142eb77047384
81e08d

quoted

quoted

e80d303e5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6390898
4094660

quoted

quoted

3723%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwL
jAuMDAw

quoted

quoted

MCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C
&sda

quoted

quoted

ta=4JQjEBcOsTdGVZZxRf2ov1IkD4DizXpsfNhMBZQVnIs%3D&reserved=0
rnel.org%2Fr%2F20260311154955.145120-3-

krzysztof.kozlowski%40oss.qualcomm.com&data=05%7C02%7Csherry.sun%4

quoted

quoted

0nxp.com%7Cc630bed6bc4f46715b4408de80675002%7C686ea1d3bc2b4c6fa

quoted

quoted

92cd99c5c301635%7C0%7C0%7C639089378371805072%7CUnknown%7CTWF

quoted

quoted

pbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4

quoted

quoted

zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=A%2BiFa

quoted

quoted

kDVdjPn0JJxUDlTDt1ej4iqnBivDktjwbcpFK4%3D&reserved=0
---
 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 8
++++++++
 1 file changed, 8 insertions(+)

diff --git
a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
index 12a01f7a5744..12cd1b9f78d0 100644

--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml

@@ -62,6 +62,9 @@ properties:
     description: Should specify the GPIO for controlling the PCI bus device
       reset signal. It's not polarity aware and defaults to active-low reset
       sequence (L=reset state, H=operation state) (optional required).
+      Deprecated, use reset-gpios which respects the polarity expressed in
+      phandle argument.
+    deprecated: true

   reset-gpio-active-high:
     description: If present then the reset sequence using the GPIO

Hi Krzysztof,
This property also needs to be deprecated as Rob suggested in my
previous patch :)
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore
.kernel.org%2Fall%2F20260121164002.GA3427694-

robh%40kernel.org%2F&data

quoted

=05%7C02%7Csherry.sun%40nxp.com%7C6967142eb7704738481e08de80d3
03e5%7C6

quoted

86ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C639089840946618268%7
CUnknown

quoted

%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIl

AiOiJXaW4

quoted

zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=duSx4R
MO9WjKX

quoted

0aUSEM49tQpEpUEc%2B7aVATwASdFSGE%3D&reserved=0

Heh, why that patchset isn't merged already?

The V8 patch set is still under reviewing due to some pcie driver part changes ;)
https://lore.kernel.org/linux-devicetree/20260313020823.1592389-1-sherry.sun@nxp.com/ (local)

Best Regards
Sherry