Re: [net-next,v9,1/4] dt-bindings: net: Add support for Spacemit K3 dwmac
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-03-13 02:34:23
Also in:
linux-devicetree, linux-riscv, lkml, netdev, spacemit
This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- dt-bindings: net: Add support for Spacemit K3 dwmac The GMAC IP on Spacemit K3 is almost a standard Synopsys DesignWare MAC (version 5.40a) with some extra clock. This patch adds the necessary compatible string for this device, along with a new binding document defining the required properties.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 38bc34dc4f09..98ebb6276bc6 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml@@ -109,6 +109,7 @@ properties: - snps,dwmac-5.10a - snps,dwmac-5.20 - snps,dwmac-5.30a + - snps,dwmac-5.40a - snps,dwxgmac - snps,dwxgmac-2.10 - sophgo,sg2042-dwmac
[ ... ]
quoted hunk ↗ jump to hunk
@@ -656,6 +657,7 @@ allOf: - snps,dwmac-5.10a - snps,dwmac-5.20 - snps,dwmac-5.30a + - snps,dwmac-5.40a - snps,dwxgmac - snps,dwxgmac-2.10 - st,spear600-gmac
Is snps,dwmac-5.40a missing from the select block? The binding document has
a comment at lines 14-17 stating:
# Select every compatible, including the deprecated ones. This way, we
# will be able to report a warning when we have that compatible, since
# we will validate the node thanks to the select.
Every other snps,dwmac-* version from 3.40a through 5.30a appears in all three
locations: the select block (lines 19-43), the properties.compatible enum
(lines 95-118), and the allOf conditional block (lines 643-673). However,
snps,dwmac-5.40a only appears in the properties.compatible enum and the allOf
block.
Without the entry in the select block, a device tree node using
'snps,dwmac-5.40a' as a standalone compatible (without a vendor-specific first
entry like 'spacemit,k3-dwmac') would not be selected by this schema for
validation.
[ ... ]