RE: [PATCH v4 1/4] dt-bindings: PCI: pci-imx6: Change maxItems of clocks and clock-names to 6
From: Hongxing Zhu <hongxing.zhu@nxp.com>
Date: 2026-03-11 06:31:35
Also in:
imx, linux-devicetree, linux-pci, lkml
-----Original Message----- From: Krzysztof Kozlowski <krzk@kernel.org> Sent: 2026年3月11日 14:18 To: Hongxing Zhu <hongxing.zhu@nxp.com> Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; bhelgaas@google.com; Frank Li [off-list ref]; l.stach@pengutronix.de; lpieralisi@kernel.org; kwilczynski@kernel.org; mani@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; imx@lists.linux.dev; linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/4] dt-bindings: PCI: pci-imx6: Change maxItems of clocks and clock-names to 6 On Tue, Mar 10, 2026 at 03:54:56PM +0800, Richard Zhu wrote:quoted
Previous commit 1352f58d7c8d ("dt-bindings: PCI: pci-imx6: Add external reference clock input")Please run scripts/checkpatch.pl on the patches and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' on the patches and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. Please read: https://elixir.boo/ tlin.com%2Flinux%2Fv6.12-rc3%2Fsource%2FDocumentation%2Fprocess%2Fsub mitting-patches.rst%23L577&data=05%7C02%7Chongxing.zhu%40nxp.com%7C 0ab010f0a2344157b9e208de7f35f689%7C686ea1d3bc2b4c6fa92cd99c5c3016 35%7C0%7C0%7C639088066900523007%7CUnknown%7CTWFpbGZsb3d8eyJFb XB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFp bCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=4dDw4GIiEVwRjnZhYgfL7sKm udjcs8ciDKi022n78zQ%3D&reserved=0 If a tag was not added on purpose, please state why and what changed. </form letter>
Hi Krzysztof: I just received your tag in [PATCH v3 1/4] at 4:00 PM after I sent out the v4 patch-set at 3:53 PM. That's why it's missed in [PATCH v4 1/4]. The tag would be added in next version. Best Regards Richard Zhu