Thread (9 messages) 9 messages, 4 authors, 2026-03-31

Re: [PATCH v4 3/3] arm64: dts: rockchip: Add Orange Pi 5 Pro board support

From: Jimmy Hon <hidden>
Date: 2026-03-11 00:20:31
Also in: linux-devicetree, linux-rockchip, lkml

<snip>
+
+       vcc5v0_otg: regulator-vcc5v0-otg {
+               compatible = "regulator-fixed";
+               enable-active-high;
+               gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_HIGH>;
+               pinctrl-names = "default";
+               pinctrl-0 = <&vcc5v0_otg_en>;
+               regulator-always-on;
+               regulator-boot-on;
regulator-always-on and regulator-boot-on does not seem right.

Why were these added? The vendor did not have them.
https://github.com/orangepi-xunlong/linux-orangepi/blob/232ed4b97b65da2b7b647c4e3c496f8594b9f3f1/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-pro.dts#L216-L226

Was this mistakenly taken from the regulator usb 20 which is powering
the onboard usb2.0 hub?
https://github.com/orangepi-xunlong/linux-orangepi/blob/232ed4b97b65da2b7b647c4e3c496f8594b9f3f1/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-pro.dts#L111-L119
+               regulator-max-microvolt = <5000000>;
+               regulator-min-microvolt = <5000000>;
+               regulator-name = "vcc5v0_otg";
+               vin-supply = <&vcc5v0_sys>;
+       };
<snip>


Jimmy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help