[PATCH v2 04/12] clk: scpi: drop determine_rate op and use CLK_ROUNDING_NOOP flag
From: Brian Masney <bmasney@redhat.com>
Date: 2026-03-09 14:39:32
Also in:
arm-scmi, linux-clk, lkml
Subsystem:
common clk framework, system control & power/management interface (scpi/scmi) message protocol drivers, the rest · Maintainers:
Michael Turquette, Stephen Boyd, Sudeep Holla, Linus Torvalds
This clk driver has a noop determine_rate clk op. Drop this empty function, and enable the CLK_ROUNDING_NOOP flag. Reviewed-by: Sudeep Holla <sudeep.holla@kernel.org> Signed-off-by: Brian Masney <bmasney@redhat.com> --- To: Sudeep Holla <sudeep.holla@kernel.org> To: Michael Turquette <mturquette@baylibre.com> To: Stephen Boyd <sboyd@kernel.org> Cc: Cristian Marussi <cristian.marussi@arm.com> Cc: arm-scmi@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-clk@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/clk/clk-scpi.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/clk/clk-scpi.c b/drivers/clk/clk-scpi.c
index 7806569cd0d5c4e32700edb10e4edf2185610a81..f5d0234ad4ad77e4333613139a8ee034b949d01f 100644
--- a/drivers/clk/clk-scpi.c
+++ b/drivers/clk/clk-scpi.c@@ -32,18 +32,6 @@ static unsigned long scpi_clk_recalc_rate(struct clk_hw *hw, return clk->scpi_ops->clk_get_val(clk->id); } -static int scpi_clk_determine_rate(struct clk_hw *hw, - struct clk_rate_request *req) -{ - /* - * We can't figure out what rate it will be, so just return the - * rate back to the caller. scpi_clk_recalc_rate() will be called - * after the rate is set and we'll know what rate the clock is - * running at then. - */ - return 0; -} - static int scpi_clk_set_rate(struct clk_hw *hw, unsigned long rate, unsigned long parent_rate) {
@@ -54,7 +42,6 @@ static int scpi_clk_set_rate(struct clk_hw *hw, unsigned long rate, static const struct clk_ops scpi_clk_ops = { .recalc_rate = scpi_clk_recalc_rate, - .determine_rate = scpi_clk_determine_rate, .set_rate = scpi_clk_set_rate, };
@@ -156,6 +143,7 @@ scpi_clk_ops_init(struct device *dev, const struct of_device_id *match, if (IS_ERR(sclk->info)) return PTR_ERR(sclk->info); } else if (init.ops == &scpi_clk_ops) { + init.flags |= CLK_ROUNDING_NOOP; if (sclk->scpi_ops->clk_get_range(sclk->id, &min, &max) || !max) return -EINVAL; } else {
--
2.53.0