Re: [PATCH v7 3/5] i2c: davinci: calculate bus freq from Hz instead of kHz
From: Andy Shevchenko <hidden>
Date: 2026-03-09 11:33:27
Also in:
linux-i2c, lkml
From: Andy Shevchenko <hidden>
Date: 2026-03-09 11:33:27
Also in:
linux-i2c, lkml
On Mon, Mar 09, 2026 at 12:14:15PM +0100, Marcus Folkesson wrote:
On Mon, Feb 23, 2026 at 04:59:49PM +0200, Andy Shevchenko wrote:quoted
On Mon, Feb 23, 2026 at 03:33:52PM +0100, Marcus Folkesson wrote:
...
quoted
quoted
+ dev_dbg(dev->dev, "bus_freq_hz = %dHz\n", dev->bus_freq_hz);%u ?Thank you for your comments, both this and the other. This driver has a a few other style & formatting issues, would you prefer to fix those in a separate patch in this patchset or in a following one?
Depending on the issues and churn it makes. In cases you already touched the lines these (what I mentioned) can be done at the same time as they do not change the logic. (Yes, theoretically you may get -BIG NUMBER for big frequencies, but I do not believe we have 2+GHz for any I²C controller in the world, so IRL it's close to impossible.) -- With Best Regards, Andy Shevchenko