Re: [EXT] Re: [PATCH v4 3/4] clocksource/drivers/timer-mediatek: Convert timer-mediatek to a loadable module
From: Trilok Soni <hidden>
Date: 2026-03-09 06:14:15
Also in:
imx, linux-mediatek, lkml
On 3/8/2026 10:31 PM, Zhipeng Wang wrote:
Hello Daniel, I'd be very happy to collaborate on this! My availability: I can dedicate time to work on this over the next few weeks. I'm happy to help with: - Testing the new macros with IMX timer drivers - Converting existing drivers as examples - Reviewing and testing patches - Documentation My understanding is that, based on your RFC, we should use two macros — TIMER_OF_DECLARE_PDEV and TIMER_OF_DECLARE_PLATFORM_DRIVER. BRs, Zhipeng
Please don't top post and something is wrong w/ your email fonts. Please fix.
quoted
-----Original Message----- From: Daniel Lezcano <redacted> Sent: 2026年3月9日 3:51 To: Zhipeng Wang <redacted> Cc: daniel.lezcano@linaro.org; tglx@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; matthias.bgg@gmail.com; angelogioacchino.delregno@collabora.com; linux-kernel@vger.kernel.org; imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org; linux-mediatek@lists.infradead.org; chun-hung.wu@mediatek.com; walter.chang@mediatek.com; jstultz@google.com; amergnat@baylibre.com; Aisheng Dong [off-list ref]; Jindong Yue [off-list ref]; Xuegang Liu [off-list ref]; Greg Kroah-Hartman [off-list ref] Subject: Re: [EXT] Re: [PATCH v4 3/4] clocksource/drivers/timer-mediatek: Convert timer-mediatek to a loadable module [You don't often get email from daniel.lezcano@oss.qualcomm.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button On 3/6/26 06:46, Zhipeng Wang wrote:quoted
Hi Daniel, Thank you for sharing your RFC patch. I think the approach is very interesting and addresses a real problem in the timer subsystem. For the MediaTek and IMX timer driver, I see a few considerations: 1. Current approach: My current patch uses the existing pattern (similar to renesas-ostm.c) with #ifdef MODULE. It's simple and works, but I agree it's not ideal. 2. Your approach: Your TIMER_OF_DECLARE_PDEV approach would be cleaner and allow us to use devm_ functions, which would be a nice improvement. 3. MediaTek and IMX timer specifics: The IMX timer doesn't require early initialization on modern platforms (we have arch timers on ARM64), so it would fit well with yourTIMER_OF_DECLARE_PLATFORM_DRIVERquoted
macro (if you go with the two-macro approach). I'm very interested in your approach. May I ask what timeline you're considering for your patch series? The reason I ask is that we're working towards GKI support and I want to make sure I choose the right approach.Well, if you are willing to collaborate, we can start right now to think about it and propose an unified solution