Re: [PATCH v1] arm64: dts: freescale: imx95-toradex-smarc: Support Cortex M7
From: Daniel Baluta <hidden>
Date: 2026-03-04 16:08:07
Also in:
imx, linux-devicetree, lkml
On 3/3/26 23:01, Frank Li wrote:
From: Frank Li (AI-BOT) <frank.li@nxp.com> AI bot review and may be useless. ---quoted
+ cm7: remoteproc-cm7 { + compatible = "fsl,imx95-cm7"; + mbox-names = "tx", "rx", "rxdb"; + mboxes = <&mu7 0 1 + &mu7 1 1 + &mu7 3 1>; + memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>, + <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>, <&m7_reserved>; + };Line 51 exceeds 80 columns; consider breaking memory-region into multiple lines for readability.
Frank please relax your bot!
As of commit bdc48fa11e46f867ea ("checkpatch/coding-style: deprecate 80-column warning")
there is no such requirement for wrapping at 80 chars anymore.
<snip>
quoted
+&mu7 { + status = "okay"; +};Ensure mu7 node is defined elsewhere in the base device tree; this patch only enables it without defining its properties.
Well it should fail compilation if mu7 was not defined? Sometimes this comments can be confusing so please review them carefully before replying.