Re: [PATCH 1/1] dmaengine: xilinx: xdma: Fix regmap init error handling
From: Alexander Stein <hidden>
Date: 2026-03-04 14:16:02
Also in:
dmaengine, lkml
Am Dienstag, 14. Oktober 2025, 08:13:08 CET schrieb Alexander Stein:
devm_regmap_init_mmio returns an ERR_PTR() upon error, not NULL.
Fix the error check and also fix the error message. Use the error code
from ERR_PTR() instead of the wrong value in ret.
Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver")
Signed-off-by: Alexander Stein <redacted>Ping, any feedback? Thanks Alexander
quoted hunk ↗ jump to hunk
--- drivers/dma/xilinx/xdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c index 3d9e92bbc9bb0..c5fe69b98f61d 100644 --- a/drivers/dma/xilinx/xdma.c +++ b/drivers/dma/xilinx/xdma.c@@ -1325,8 +1325,8 @@ static int xdma_probe(struct platform_device *pdev) xdev->rmap = devm_regmap_init_mmio(&pdev->dev, reg_base, &xdma_regmap_config); - if (!xdev->rmap) { - xdma_err(xdev, "config regmap failed: %d", ret); + if (IS_ERR(xdev->rmap)) { + xdma_err(xdev, "config regmap failed: %pe", xdev->rmap); goto failed; } INIT_LIST_HEAD(&xdev->dma_dev.channels);
-- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/
Attachments
- signature.asc [application/pgp-signature] 488 bytes