Hi Bart,

On 3/2/2026 1:51 AM, Bart Van Assche wrote:

On 3/1/26 6:26 AM, Can Guo wrote:

quoted

On 2/28/2026 3:31 AM, Bart Van Assche wrote:

quoted

On 2/27/26 8:07 AM, Can Guo wrote:

quoted

-    return -ENOTSUPP;
+    return -EOPNOTSUPP;

Why has ENOTSUPP been changed into EOPNOTSUPP?

I got a warning from checkpatch.pl when I add the new vops, so I 
changed the same for
ufshcd_vops_pwr_change_notify() too.

WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP

Hi Can,

SUSv4 = Single UNIX Specification, Version 4. This is a standard that
defines how system calls should behave. Hence, ENOTSUPP must not be
returned as an error value by e.g. sysfs callbacks. As far as I know the
ufshcd_vops_pwr_change_notify() return value is never returned to user
space and hence returning ENOTSUPP from inside this function is fine.

If you want to keep this change in ufshcd_vops_pwr_change_notify()
please make it a separate patch.

Thanks for the info. I will use ENOTSUPP in next version.

Best Regards,
Can Guo.

Thanks,

Bart.