Thread (4 messages) 4 messages, 2 authors, 2026-02-23

Re: [PATCH net-next 1/2] net: stmmac: use circ_buf helpers for descriptors

From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2026-02-23 12:02:31
Also in: netdev

On Mon, Feb 23, 2026 at 11:41:46AM +0000, Russell King (Oracle) wrote:
quoted hunk ↗ jump to hunk
@@ -4571,8 +4562,8 @@ static netdev_tx_t stmmac_tso_xmit(struct sk_buff *skb, struct net_device *dev)
 	/* If we only have one entry used, then the first entry is the last
 	 * segment.
 	 */
-	is_last_segment = ((tx_q->cur_tx - first_entry) &
-			   (priv->dma_conf.dma_tx_size - 1)) == 1;
+	is_last_segment = CIRC_CNT(tx_q->cur_tx, first_entry,,
+				   priv->dma_conf.dma_tx_size) == 1;
Bah, I thought I fixed that, but it seems I merged the fix patch into
the second patch not this patch. :/

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help