[PATCH] drm/rockchip: vop2: Use drm_err_ratelimited() for wait timeouts
From: Hsieh Hung-En <hidden>
Date: 2026-02-09 16:17:02
Also in:
dri-devel, linux-rockchip
Subsystem:
arm/rockchip soc support, drm drivers, drm drivers and misc gpu patches, drm drivers for rockchip, the rest · Maintainers:
Heiko Stuebner, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Sandy Huang, Heiko Stübner, Andy Yan, Linus Torvalds
Replace deprecated DRM_DEV_ERROR() with drm_err_ratelimited() in the VOP2 register wait timeout paths to align with current DRM logging helpers and avoid flooding the kernel log when timeouts repeat. Signed-off-by: Hsieh Hung-En <redacted> --- drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
index f3950e8476a7..02a788a4dfdd 100644
--- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
+++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c@@ -2106,8 +2106,8 @@ static void rk3568_vop2_wait_for_port_mux_done(struct vop2 *vop2) ret = readx_poll_timeout_atomic(rk3568_vop2_read_port_mux, vop2, port_mux_sel, port_mux_sel == vop2->old_port_sel, 10, 50 * 1000); if (ret) - DRM_DEV_ERROR(vop2->dev, "wait port_mux done timeout: 0x%x--0x%x\n", - port_mux_sel, vop2->old_port_sel); + drm_err_ratelimited(vop2->drm, "wait port_mux done timeout: 0x%x--0x%x\n", + port_mux_sel, vop2->old_port_sel); } static u32 rk3568_vop2_read_layer_cfg(struct vop2 *vop2)
@@ -2126,8 +2126,8 @@ static void rk3568_vop2_wait_for_layer_cfg_done(struct vop2 *vop2, u32 cfg) ret = readx_poll_timeout_atomic(rk3568_vop2_read_layer_cfg, vop2, atv_layer_cfg, atv_layer_cfg == cfg, 10, 50 * 1000); if (ret) - DRM_DEV_ERROR(vop2->dev, "wait layer cfg done timeout: 0x%x--0x%x\n", - atv_layer_cfg, cfg); + drm_err_ratelimited(vop2->drm, "wait layer cfg done timeout: 0x%x--0x%x\n", + atv_layer_cfg, cfg); } static void rk3568_vop2_setup_layer_mixer(struct vop2_video_port *vp)
--
2.34.1