Thread (2 messages) 2 messages, 1 author, 2026-02-23

Re: [PATCH] pinctrl: rockchip: use *enum* properly in rockchip_pinconf_pull_valid()

From: Sergey Shtylyov <hidden>
Date: 2026-02-23 20:03:35
Also in: linux-gpio, linux-rockchip

On 2/23/26 10:44 PM, Sergey Shtylyov wrote:
In rockchip_pinconf_pull_valid(), the pull parameter has *enum* type that
is not isomorphic with boolean type but it's used as a boolean expression
in the ?: operator.  Compare pull with PIN_CONFIG_BIAS_BUS_HOLD instead,
dropping the unnecessary ?: operator as well...

Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.

Signed-off-by: Sergey Shtylyov <redacted>
[...]

   Forgot to add that the patch wass against the for-next branch of Linus W.'s
linux-pinctrl.git repo.

MBR, Sergey

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help