Re: [PATCH RFC net-next 5/9] net: stmmac: qcom-ethqos: move loopback disable to .mac_finish()
From: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Date: 2026-02-17 18:38:17
Also in:
imx, linux-arm-msm, netdev
On Thu, Feb 12, 2026 at 12:18:06AM +0000, Russell King (Oracle) wrote:
Loopback is enabled to allow the dwmac soft reset to succeed. This is enabled when clocks are enabled in ethqos_clks_config(), which happens at driver probe and runtime PM resume - e.g. when the network device is administratively brought up. Currently, the loopback is disabled when the link comes up (via .mac_link_up() calling this driver's .fix_mac_speed().) Move the qcom_ethqos_set_sgmii_loopback() call which disables loopback from ethqos_fix_mac_speed() into ethqos' SerDes specific .mac_finish() method so that loopback is disabled a little earlier after reset has completed, and dwmac setup has completed. Signed-off-by: Russell King (Oracle) <redacted>
Reviewed-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com> Ayaan